Skip to content

BUG: DatetimeIndex.unique numpy 1.6 repr #2563 #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: DatetimeIndex.unique numpy 1.6 repr #2563 #2568

wants to merge 1 commit into from

Conversation

changhiskhan
Copy link
Contributor

wesm
wesm reviewed Dec 19, 2012
View reviewed changes
pandas/tseries/index.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, did you test the performance impact of this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just returning a DatetimeIndex instead of a raw numpy array in this particular case

@wesm
Copy link
Member

wesm commented Dec 19, 2012

Boxing + dtype=object hash table pass (vs. int64) --> 300x slowdown. we can make this into a vbenchmark

In [48]: rng = date_range('1/1/2000', periods=10000, freq='T')

In [49]: arr = rng.repeat(10)

In [50]: timeit arr.unique()
1000 loops, best of 3: 1.11 ms per loop

In [51]: timeit arr.asobject.unique()
1 loops, best of 3: 320 ms per loop

@wesm wesm closed this Dec 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@changhiskhan @wesm